lkml.org 
[lkml]   [2011]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Kconfig: add warning about permission of config file
    From
    Hi,

    On Tue, May 24, 2011 at 11:01 AM, Michal Marek <mmarek@suse.cz> wrote:
    > On 24.5.2011 16:26, Hiromu Yakura wrote:
    >>
    >> Hello,
    >>
    >> On Fri, May 24, 2011 at 22:23, Michal Marek<mmarek@suse.cz>  wrote:
    >>>
    >>> Arnaud's point is that your patch should not be necessary at all,
    >>> because kconfig already checks the return value of the fopen() call in
    >>> conf_write() and prints the above message if it fails. So do you have a
    >>> testcase where make<...>config without your patch returns without
    >>> error, but the configuration is not written?
    >>
    >> Sorry for misunderstanding.
    >> Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...)
    >> raise error.
    >> And only xconfig and gconfig don't write the configuration without
    >> error.
    >
    > I see, qconf lacks a check for the return value of conf_write() in
    > ConfigMainWindow::closeEvent(), gconf does check the return value, but only
    > displays it in the bottom box of the main window instead of a message box.
    > Neither of them return failure in the error case. These bugs should be
    > indeed fixed.
    >
    agree.

    > But I don't like the directory permission check, it only
    > handles one case, but does not handle permission on the .config file itself
    > with KCONFIG_OVERWRITECONFIG=1, ENOSPC and so on.
    >
    seconded.

    - Arnaud
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-05-24 17:53    [W:3.743 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site