lkml.org 
[lkml]   [2011]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/10] ptrace: implement group stop notification for ptracer
Hello, Oleg.

On Tue, May 24, 2011 at 03:44:11PM +0200, Tejun Heo wrote:
> > 2. ptrace_trap_notify() always sets JOBCTL_TRAP_NOTIFY. Even if the caller
> > is prepare_signal(SIGCONT) and there were no SIGSTOP in the past. This looks
> > a bit strange to me. I mean, perhaps it would be better to provoke the trap
> > only if this SIGCONT is going to change the jobctl state.
>
> Sure. It doesn't really matter tho and might even be better for
> weeding out invalid assumptions.

Hmmm... tried to change this but I think it's better as-is. As an
optimization, it isn't whole lot meaningful, and, if I do it, I would
probably end up moving SIGNAL_STOP_STOPPED and group_stop_count test
above actual wake up and then skipping wake up if none was true - it
would make SIGCONT handling more fragile without much benefit.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-05-24 17:47    [W:0.097 / U:2.996 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site