lkml.org 
[lkml]   [2011]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] TTY: export NR_LDISC and N_* line discipline numbers to user-space
Am 24.05.2011 15:17 schrieb Florian Fainelli:
> On Tuesday 24 May 2011 14:40:44 Greg KH wrote:
>> On Tue, May 24, 2011 at 10:43:03AM +0200, Florian Fainelli wrote:
>>> From: Florian Fainelli <ffainelli@freebox.fr>
>>>
>>> Since commit (4564f9e5: consolidate line discipline number definitions)
>>> the patch moved all line discipline number from a per-architecture
>>> termios.h to a shared one: tty.h. However, prior to this consolidation
>>> work, the line discipline numbers were outside of an ifdef
>>> __KERNEL__/endif block so these numbers used to be exported to
>>> user-space.
>>>
>>> Since such numbers are kernel ABI anyway, and tty.h is already included
>>> for user- space header processing, just move these relevant defines
>>> outside of the ifdef __KERNEL__/endif block in include/linux/tty.h.
[...]
>> Meaning, why has it taken this long for anyone to notice?
>
> - long standing user-space applications such as pppd got their N_PPP long ago,
> and do not have to worry about N_PPP being renumbered so they can just define
> it in pppd's sources it won't break

Also, I just checked on openSUSE 11.2, which comes with kernel
release is 2.6.27, and it still defines the LD numbers in
/usr/include/bits/ioctl-types.h (included from sys/ioctl.h).
I guess other distributions are doing the same, so their users
wouldn't notice the change.

Anyway, the patch is fine by me. Feel free to add:

Acked-by: Tilman Schmidt <tilman@imap.cc>

Thanks,
Tilman

--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-05-24 16:13    [W:0.073 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site