lkml.org 
[lkml]   [2011]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] posix clocks: correct error value in posix_clock_poll()
    On Tue, May 24, 2011 at 12:51:47PM +0200, Nicolas Kaiser wrote:
    > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
    > ---
    > It looks to me like -ENODEV might not be a good return value
    > in poll(). Would POLLERR be the correct one in this case?
    >
    > kernel/time/posix-clock.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c
    > index c340ca6..2424d3f 100644
    > --- a/kernel/time/posix-clock.c
    > +++ b/kernel/time/posix-clock.c
    > @@ -71,7 +71,7 @@ static unsigned int posix_clock_poll(struct file *fp, poll_table *wait)
    > int result = 0;
    >
    > if (!clk)
    > - return -ENODEV;
    > + return POLLERR;

    The condition (!clk) is only satisfied when 'zombie' is set,
    indicating that the dynamic clock has disappeared. That is why the
    file operations uniformly return ENODEV. So, I think it makes sense
    the way that it is.

    In addition, man 2 poll says,

    POLLERR
    Error condition (output only).

    so using that error code would be misleading, IMHO.

    Thanks,
    Richard


    \
     
     \ /
      Last update: 2011-05-24 14:37    [W:0.064 / U:32.724 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site