[lkml]   [2011]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework
Hi Sebastian,

> >+ if (!gadget_is_superspeed(gadget))
> >+ goto unknown;
> >+ if (ctrl->bRequestType != (USB_DIR_IN |
> >+ goto unknown;
> >+ value = 2; /* This is the length of the get_status
> */
> >+ *((__le16 *)req->buf) = 0;
> Mike please correct me if I'm wrong bug this looks like a case for
> put_unaligned_le16().
> Is someone actually using gadget support on blackfin? I'm asking
> because
> config_buf() (same file, upstream) is using req->buf to build the
> descriptors in place and one element is le16 which should be affected.

Mike answered that you're right in your observation. I'm not familiar with
blackfin. Could you please elaborate on this? I understand that I need to
use put_unaligned_le16(), will do, but I would like to better understand why
and if there is a way to test this so that blackfin won't be broken.

Best regards,
Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

 \ /
  Last update: 2011-05-24 07:11    [W:0.054 / U:2.520 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site