Messages in this thread Patch in this message | | | From | Mel Gorman <> | Subject | [PATCH 1/2] mm: vmscan: Correct use of pgdat_balanced in sleeping_prematurely | Date | Mon, 23 May 2011 10:53:54 +0100 |
| |
From: Johannes Weiner <hannes@cmpxchg.org>
Johannes Weiner poined out that the logic in commit [1741c877: mm: kswapd: keep kswapd awake for high-order allocations until a percentage of the node is balanced] is backwards. Instead of allowing kswapd to go to sleep when balancing for high order allocations, it keeps it kswapd running uselessly.
Signed-off-by: Mel Gorman <mgorman@suse.de> Reviewed-by: Rik van Riel <riel@redhat.com> --- mm/vmscan.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c index 8bfd450..1aa262b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2286,7 +2286,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining, * must be balanced */ if (order) - return pgdat_balanced(pgdat, balanced, classzone_idx); + return !pgdat_balanced(pgdat, balanced, classzone_idx); else return !all_zones_ok; } -- 1.7.3.4
| |