lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for May 23 (sound/soc/codecs)
On Mon, May 23, 2011 at 06:21:51PM -0700, Randy Dunlap wrote:
> On 05/23/11 17:08, Mark Brown wrote:

> > No, really we should. The GPIO APIs are stubbed out when not in use for
> > a very good reason, think about the usability here. The goal here isn't
> > to litter the code with ifdefs - if architectures aren't able to keep up
> > with API changes they should convert to using gpiolib so this stuff
> > happens automatically (indeed, I can't think of any good reason for an
> > architecture to not be using gpiolib at this point).

> No, I would say that there are a lot of drivers in sound/soc/codecs/
> that are missing some GPIO pieces in the Kconfig file.

Have you actually looked at the code here? Vanishingly few of the
drivers need GPIOs at all, they can just optionally use GPIOs if the
system makes them available. There is absolutely no dependency on GPIOs
for them, anything in Kconfig would be entirely unconstructive.

> >> MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");

> > You've clearly not looked at MAINTAINERS for this one.

> It's not listed in the MAINTAINERS file.

MAINTAINERS has a pattern sound/soc/codecs/wm*.

> But maybe you mean scripts/get_maintainer.pl, which I did try.
> I found that using git log <that source file name> was better info
> than using scripts/get_maintainer.pl.

get_maintainers is just a script that reads MAINTAINERS and trawls logs
for it; the reason I mentioned MAINTAINERs was that you were saying you
didn't use git. In general you're better off doing things by hand
rather than using get_maintainers.


\
 
 \ /
  Last update: 2011-05-24 03:53    [W:0.098 / U:0.688 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site