lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PATCH] STAGING pull for .40
On Mon, May 23, 2011 at 01:43:13PM -0700, Linus Torvalds wrote:
> On Mon, May 23, 2011 at 12:38 PM, Greg KH <greg@kroah.com> wrote:
> > Here is the big pull request for the staging tree for your .40 tree (or
> > 2.8.0, whatever you are wanting to rename it to.)
>
> Hmm. Doing my once-a-release "try to compile everything in staging
> after pulling from greg by using allyesconfig and also forcing all
> staging",

Ugh, I keep only testing 'allmodconfig' with all staging drivers, I'll
add this to my test build setup from now on.

> I get this:
>
> drivers/staging/brcm80211/brcmsmac/built-in.o:(.data+0xba0):
> multiple definition of `wl_msg_level'
> drivers/staging/brcm80211/brcmfmac/built-in.o:(.data+0x1a94): first
> defined here
>
> which looks like another case of "can't compile two things both into
> the kernel".
>
> Looks like the BRCMSMAC / BRCMFMAC drivers need to be mutually
> exclusive. Something like
>
> depends on m || (BRCMSMAC != y)
>
> for BRCMFMAC?
>
> Or they should just avoid using the same globally visible name.

Both probably. I'll fix this up for the next set of staging fixes after
you release -rc1.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-05-24 01:03    [W:0.061 / U:5.620 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site