lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] um: use RWSEM_GENERIC_SPINLOCK on x86
On Mon, May 23, 2011 at 1:30 PM, Richard Weinberger <richard@nod.at> wrote:
>
>  config RWSEM_XCHGADD_ALGORITHM
> -       def_bool X86_XADD
> +       def_bool X86_XADD && 64BIT
>
>  config RWSEM_GENERIC_SPINLOCK
> -       def_bool !X86_XADD
> +       def_bool !X86_XADD || !64BIT

May I suggest just changing that second one to

config RWSEM_GENERIC_SPINLOCK
def_bool !RWSEM_XCHGADD_ALGORITHM

because I had to look twice just to make sure that they are inverses
of each other.

So why not make that inverse relationship more obvious?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-05-23 22:49    [W:0.024 / U:44.368 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site