lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver out of staging
Date


> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Monday, May 23, 2011 2:43 PM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; tglx@linutronix.de; johnstul@us.ibm.com;
> hch@infradead.org; Hank Janssen; Haiyang Zhang
> Subject: Re: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver out
> of staging
>
> > +#include <linux/version.h>
>
> This one shouldn't be needed.

Correct; I will fix this.
>
> > +#include <asm/hyperv.h>
> > +#include <asm/mshyperv.h>
>
> not really a review for this driver, but what's the purpose if having
> these two headers?

These header files have the defines for checking if we are running on
Hyper-V.

>
> Shouldn't the Kconfig entry also move from drivers/staging to
> arch/x86 towards the other clocksources?

Currently this driver is built if HYPERV is defined. I agree with you
that I should have Kconfig entry in arch/x86. Since the rest of the
Hyper-V drivers are still in staging, I am thinking that perhaps we should
have a different config switch - HYPERV_CLKSRC. I will go ahead and
spin a new version of this patch with this change.

Regards,

K. Y


\
 
 \ /
  Last update: 2011-05-23 21:07    [W:0.056 / U:56.476 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site