Messages in this thread | | | Date | Mon, 23 May 2011 10:07:55 -0700 | From | Randy Dunlap <> | Subject | Re: [patch v3] checkpatch: Signature format verification |
| |
On Mon, 23 May 2011 22:36:12 +0530 anish singh wrote:
> On Mon, May 23, 2011 at 10:12 PM, Joe Perches <joe@perches.com> wrote: > > > On Mon, 2011-05-23 at 09:39 -0700, Randy Dunlap wrote: > > > On Mon, 23 May 2011 09:36:38 -0700 Joe Perches wrote: > > > > On Mon, 2011-05-23 at 22:03 +0530, anish singh wrote: > > > > > \s[a-zA-Z]* => this is a regular expression for name & space b/w > > > > > Last/First name > > > > > Ex: anish kumar > > > > > .* => It is used to grep whatever follows name...in our context > > > > > mail-id > > > > > Ex: abc@bbc.com. > > > > > So, $1 will contain ...'anish kumar <anish@gmail.com>' > > > > Unless the email contains a quote or a period like: > > > > Signed-off-by: "J. Random Contributor" <jrc@domain.tld> > > > and quotes are not required (i.e., are optional) AFAIK. > > > > And still should be accepted. > > > if ($1 !~ /^\s+([a-zA-Z\s\"]*.*)/i) { > WARN("Space required after $sign\n" . > $herecurr); > } > if ($1 !~ /[\sa-zA-Z\"]*\s<.*>/i) { > WARN("Space required b/w Full Name & Mail-id:\n" .
"b/w" is not a good abbreviation (for "between" ???).
> $herecurr); > } > Qoute has been taken care too now.
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |