lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] firmware: fix GOOGLE_SMI kconfig dependency warning
On 05/22/11 22:39, Mike Waychison wrote:
>
> On May 22, 2011 5:38 PM, "Randy Dunlap" <randy.dunlap@oracle.com
> <mailto:randy.dunlap@oracle.com>> wrote:
>>
>> From: Randy Dunlap <randy.dunlap@oracle.com
> <mailto:randy.dunlap@oracle.com>>
>>
>> Is it meaningful/useful to enable EFI_VARS but not EFI?
>> That's what GOOGLE_SMI does. Make it enable EFI also.
>>
>> Fixes this kconfig dependency warning:
>>
>> warning: (GOOGLE_SMI) selects EFI_VARS which has unmet direct
> dependencies (EFI)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com
> <mailto:randy.dunlap@oracle.com>>
>> Cc: Mike Waychison <mikew@google.com <mailto:mikew@google.com>>
>
> Acked.
>
> Is this a new warning? I haven't seen it before which is weird because
> we don't use efi boot.

It's not new for 20110520, but I don't know when it began.

>> ---
>> drivers/firmware/google/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20110520.orig/drivers/firmware/google/Kconfig
>> +++ linux-next-20110520/drivers/firmware/google/Kconfig
>> @@ -13,6 +13,7 @@ menu "Google Firmware Drivers"
>> config GOOGLE_SMI
>> tristate "SMI interface for Google platforms"
>> depends on ACPI && DMI
>> + select EFI
>> select EFI_VARS
>> help
>> Say Y here if you want to enable SMI callbacks for Google
>


--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-05-23 17:19    [W:0.060 / U:2.928 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site