lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/3] perf_events: update extra shared registers management (v2)
From
On Mon, May 23, 2011 at 1:10 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2011-05-23 at 12:58 +0200, Stephane Eranian wrote:
>> There is a major issue as it stands, though. You can
>> get into an infinite loop bouncing between RSP_0 and RSP_1
>> in case there is no solution in the group, i.e., you have 3 values
>> for the extra MSR. I think you need to count the number of times
>> you've called intel_try_alt_er() with success or maintain some sort
>> of bitmask of possible alternate choices and when you exhaust that,
>> you simply fail.
>
> That should be sorted by the compare with the initial idx value, no?
> Once its back where it started out it'll bail.
>
Nope.

Take:
- ev1=rsp_0:0x1001
- ev2=rsp_0:0x1002
- ev3=rsp_1:0x1008

ev1-> rsp_0
ev2-> rsp_0, conflict, then try yields rsp_1 -> ok
ev3 -> rsp_1, conflict, then rsp_0, but fails, try again -> rsp_1,
fails, and so on

The issue is that the intel_try() function does not know the
history of the swaps between rsp_0, rsp1.


\
 
 \ /
  Last update: 2011-05-23 14:03    [W:0.056 / U:69.360 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site