lkml.org 
[lkml]   [2011]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator: Fix off-by-one value range checking for mc13xxx_regulator_get_voltage
From
Date
On Wed, 2011-05-18 at 20:56 +0800, Axel Lin wrote:
> We use val as array index,
> thus the valid value rangae for val should be 0 .. n_voltages-1.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/regulator/mc13xxx-regulator-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
> index 2bb5de1..bc27ab1 100644
> --- a/drivers/regulator/mc13xxx-regulator-core.c
> +++ b/drivers/regulator/mc13xxx-regulator-core.c
> @@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev)
>
> dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val);
>
> - BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages);
> + BUG_ON(val >= mc13xxx_regulators[id].desc.n_voltages);
>
> return mc13xxx_regulators[id].voltages[val];
> }

Applied

Thanks

Liam



\
 
 \ /
  Last update: 2011-05-21 13:57    [W:0.035 / U:28.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site