lkml.org 
[lkml]   [2011]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/7] overlay filesystem (inode.c bad error path)
From
Date
On May 20, 2011, at 10:25 AM, Miklos Szeredi wrote:

> Erez Zadok <ezk@fsl.cs.sunysb.edu> writes:
>> Niklos, I forgot to mention that I had to apply a small fix to a VFS
>> bug in fs/namei.c:1362, where a mix of symlinks and renames, using
>> racer, triggers an BUG_ON at the VFS layer (very reproducible).
>> Without this fix, racer oopses in the VFS well before it gets to
>> trigger overlayfs bugs. It's a pity 2.6.39 was released with this
>> very reproducible *VFS* level bug (doesn't anyone run racer+fsx+ltp
>> before releasing a new kernel?)
>>
>> Anyway, here's the small patch here. Clearly viro/hch need to review
>> this "fix" b/c I'm not sure it's really the right one
>
> Patch looks good to me.
>
> Acked-by: Miklos Szeredi <mszeredi@suse.cz>
>
> If you've got a patch fixing a serious bug, you'd better send it to
> Linus and Andrew (as well as the VFS maintainers), where it'll get more
> prompt evaluation.
>
> You can still do that, also adding "CC: stable@kernel.org" to the SOB
> block in the patch so that the fix quickly makes it into the 2.6.39
> stable series.
>
> Thanks,
> Miklos

Thanks. I'll do that.

Erez.



\
 
 \ /
  Last update: 2011-05-21 07:19    [W:0.126 / U:2.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site