lkml.org 
[lkml]   [2011]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] x86: UV uv_tlb.c cleanup

* Cliff Wickman <cpw@sgi.com> wrote:

> One logic difference:
> Breaking uv_init_per_cpu() into get_cpu_topology() and summarize_uvhub_sockets()
> actually corrects a possible bug for the theoretical case in which there is a
> missing socket on a blade. An 'smaster' (socket master) had been expected for
> every socket.

Please, as i asked in the previous mail, do not add logic changes to the
cleanup patch! Please keep it in a separate patch, after the big cleanup patch.

It will be very hard to debug if you find a regression in that cleanup patch:
since it also changes logic you do not know whether it's due to changed logic
or one of the cleanups having an unintended side-effect ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-21 12:41    [W:0.078 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site