lkml.org 
[lkml]   [2011]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] VFS: Add VFS event counter infrastructure

Any comments on where I placed the counters?

> > This patch implements a simple per CPU counter framework for the VFS.
> > The counters are per CPU and are very little overhead. The counters
> > are output in debugfs (/sys/kernel/fs/vfsstat)
>
> WTF? Since when had debugfs become mandatory?

What do you mean? It's not mandatory of course.

I had it originally in /proc, but then moved it to debugfs.

>
> > + fs = debugfs_create_dir("fs", NULL);
> > + if (fs)
> > + debugfs_create_file("vfsstat", 0444, fs, NULL, &vfsstat_fops);
> > + return 0;
>
> Note that if that FPOS is configured away debugfs_create_dir() does _NOT_
> return NULL - you get ERR_PTR(-ENODEV).

That's fine because debugfs_create_file is a noop then too
and fs isn't used anywhere else.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2011-05-22 04:27    [W:0.037 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site