lkml.org 
[lkml]   [2011]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] x86, x2apic: minimize IPI register writes using cluster groups v4

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> On 05/02/2011 06:02 PM, Cyrill Gorcunov wrote:
> ...
> >
> > Ingo, the idea was to merge probe_x.c completely, and put all this not into init()
> > but rather into apic->probe() or something like that. I don't have a clear picture
> > in mind yet what the best way would be, so instead of fast designed method I thought
> > to leave it opencoded with fixme note.
> >
> > So lets wait until Suresh post the benchmark and I will make apic->init() meanwhile.
> >
>
> Ingo, would it be fine to make apic->init() either _before_ this series or
> on top of them (because if I introduce it inside this particular patch it
> would contain some unrelated code snippets such as .init = NULL for all apics
> declaration).

Of course it should be a separate patch - even this patch looks a bit large -
any way to split it up further?

And yes, if it fits it should be in apic->probe() instead of introducing a new
->init() method.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-02 17:09    [W:0.136 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site