This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Fri Apr 26 11:36:39 2024 Delivery-date: Fri, 20 May 2011 05:00:28 +0200 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:53403 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757081Ab1ETDAQ (ORCPT ); Thu, 19 May 2011 23:00:16 -0400 Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 066723EE0C1 for ; Fri, 20 May 2011 12:00:14 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id E411545DF54 for ; Fri, 20 May 2011 12:00:13 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id CD81445DF52 for ; Fri, 20 May 2011 12:00:13 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id C19BB1DB8038 for ; Fri, 20 May 2011 12:00:13 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.240.81.134]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 8B3371DB803A for ; Fri, 20 May 2011 12:00:13 +0900 (JST) Received: from ml14.css.fujitsu.com (ml14 [127.0.0.1]) by ml14.s.css.fujitsu.com (Postfix) with ESMTP id 3AA779F6F6A; Fri, 20 May 2011 12:00:13 +0900 (JST) Received: from [127.0.0.1] (unknown [10.124.101.131]) by ml14.s.css.fujitsu.com (Postfix) with ESMTP id B841B9F6F56; Fri, 20 May 2011 12:00:12 +0900 (JST) X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Received: from KOSANOTE2[10.124.101.131] by KOSANOTE2 (FujitsuOutboundMailChecker v1.3.1/9992[10.124.101.131]); Fri, 20 May 2011 12:00:11 +0900 (JST) Message-Id: <4DD5D92B.8030209@jp.fujitsu.com> Date: Fri, 20 May 2011 11:59:55 +0900 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 Mime-Version: 1.0 To: linux-mm@kvack.org, yinghan@google.com, linux-kernel@vger.kernel.org Cc: kosaki.motohiro@jp.fujitsu.com Subject: Re: [PATCH V2 2/2] change shrinker API by passing shrink_control struct Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org > Hmm, got Nick's email wrong. > > --Ying Ping. Can you please explain current status? When I can see your answer? > > On Tue, Apr 26, 2011 at 6:15 PM, Ying Han wrote: >> On Tue, Apr 26, 2011 at 5:47 PM, KOSAKI Motohiro >> wrote: >>>> > > { >>>> > >    struct xfs_mount *mp; >>>> > >    struct xfs_perag *pag; >>>> > >    xfs_agnumber_t ag; >>>> > >    int       reclaimable; >>>> > > +   int nr_to_scan = sc->nr_slab_to_reclaim; >>>> > > +   gfp_t gfp_mask = sc->gfp_mask; >>>> > >>>> > And, this very near meaning field .nr_scanned and .nr_slab_to_reclaim >>>> > poped up new question. >>>> > Why don't we pass more clever slab shrinker target? Why do we need pass >>>> > similar two argument? >>>> > >>>> >>>> I renamed the nr_slab_to_reclaim and nr_scanned in shrink struct. >>> >>> Oh no. that's not naming issue. example, Nick's previous similar patch pass >>> zone-total-pages and how-much-scanned-pages. (ie shrink_slab don't calculate >>> current magical target scanning objects anymore) >>>    ie, "4 * max_pass * (scanned / nr- lru_pages-in-zones)" >>> >>> Instead, individual shrink_slab callback calculate this one. >>> see git://git.kernel.org/pub/scm/linux/kernel/git/npiggin/linux-npiggin.git >>> >>> I'm curious why you change the design from another guy's previous very similar effort and >>> We have to be convinced which is better. >> >> Thank you for the pointer. My patch is intended to consolidate all >> existing parameters passed from reclaim code >> to the shrinker. >> >> Talked w/ Nick and Andrew from last LSF, we agree that this patch >> will be useful for other extensions later which allows us easily >> adding extensions to the shrinkers without shrinker files. Nick and I >> talked about the effort later to pass the nodemask down to the >> shrinker. He is cc-ed in the thread. Another thing I would like to >> repost is to add the reclaim priority down to the shrinker, which we >> won't throw tons of page caches pages by reclaiming one inode slab >> object. >> >> --Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/