| From | Greg Kroah-Hartman <> | Subject | [PATCH 02/44] efivars: memory leak on error in create_efivars_bin_attributes() | Date | Thu, 19 May 2011 17:10:20 -0700 |
| |
From: Dan Carpenter <error27@gmail.com>
This is a cut and paste bug. We intended to free ->del_var and ->new_var but we only free ->new_var.
Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Mike Waychison <mikew@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index ff0c373..ff2fe40 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -677,8 +677,8 @@ create_efivars_bin_attributes(struct efivars *efivars) return 0; out_free: - kfree(efivars->new_var); - efivars->new_var = NULL; + kfree(efivars->del_var); + efivars->del_var = NULL; kfree(efivars->new_var); efivars->new_var = NULL; return error; -- 1.7.4.2
|