lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 01/21] integrity: move ima inode integrity data management
From
Date
On Wed, 2011-05-18 at 21:06 -0500, Serge E. Hallyn wrote: 
> Quoting Mimi Zohar (zohar@linux.vnet.ibm.com):
> > Move the inode integrity data(iint) management up to the integrity directory
> > in order to share the iint among the different integrity models.
>
> You also
>
> rename several globally visible ima_* functions, structs, locks etc to
> integrity_\0
> replace '20' by SHA1_DIGEST_SIZE
> remove unnecessary initialization of iint_initialized to 0

Yes, will update the changelog to reflect these changes as well.

> Which all are fine, but probably should be mentioned in changelog,
> along with the magic phrase "no other functional changes" to aid
> reviewers.

Wasn't aware of this.

> > Changelog:
> > - Rebased on current ima_iint.c
> > - Define integrity_iint_store/lock as static
> >
> > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
>
> Acked-by: Serge Hallyn <serge.hallyn@ubuntu.com>
>
> thanks,
> -serge

Thanks!

Mimi



\
 
 \ /
  Last update: 2011-05-20 00:47    [W:0.303 / U:2.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site