Messages in this thread | | | Date | Thu, 19 May 2011 14:04:41 -0700 | From | Mark Brown <> | Subject | Re: [PATCH] mfd wm8350: allocate irq descs dynamically |
| |
On Thu, May 19, 2011 at 08:56:48PM +0200, Sascha Hauer wrote:
> - if (!pdata || !pdata->irq_base) { > - dev_warn(wm8350->dev, "No interrupt support, no IRQ base\n"); > + if (!pdata) { > + dev_warn(wm8350->dev, "No interrupt support, no platform data\n");
This isn't terribly good, the only reason we're checking pdata here is because we can't dereference it to look up irq_base if it's not there.
| |