Messages in this thread | | | Date | Thu, 19 May 2011 16:16:13 -0400 (EDT) | Subject | Re: [PATCH] tcp: Lower the initial RTO to 1s as per draft RFC 2988bis-02. | From | David Miller <> |
| |
From: Benoit Sigoure <tsunanet@gmail.com> Date: Wed, 18 May 2011 23:47:49 -0700
> @@ -868,6 +868,11 @@ static void tcp_init_metrics(struct sock *sk) > { > struct tcp_sock *tp = tcp_sk(sk); > struct dst_entry *dst = __sk_dst_get(sk); > + /* If we had to retransmit anything during the 3WHS, use > + * the initial fallback RTO as per draft RFC 2988bis-02. > + */ > + int init_rto = inet_csk(sk)->icsk_retransmits ? > + TCP_TIMEOUT_INIT_FALLBACK : TCP_TIMEOUT_INIT;
Please do not put comments in the middle of a set of function local variable declarations.
Also, as mentioned already, icsk_retransmits is not where SYN retransmissions are counted.
It is stored in the TCP minisocket ->retrans field.
| |