lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[38/71] slcan: fix ldisc->open retval
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Oliver Hartkopp <socketcan@hartkopp.net>

    commit 0d4420a90b51abdea71585f571bad6d789ff8eb7 upstream.

    TTY layer expects 0 if the ldisc->open operation succeeded.

    Reported-by: Matvejchikov Ilya <matvejchikov@gmail.com>
    Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/can/slcan.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/net/can/slcan.c
    +++ b/drivers/net/can/slcan.c
    @@ -583,7 +583,9 @@ static int slcan_open(struct tty_struct
    /* Done. We have linked the TTY line to a channel. */
    rtnl_unlock();
    tty->receive_room = 65536; /* We don't flow control */
    - return sl->dev->base_addr;
    +
    + /* TTY layer expects 0 on success */
    + return 0;

    err_free_chan:
    sl->tty = NULL;



    \
     
     \ /
      Last update: 2011-05-19 20:21    [W:2.718 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site