lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[61/71] [media] Fix cx88 remote control input
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Lawrence Rust <lvr@softsystem.co.uk>

    commit 2a164d02dd34c6b49a3f0995900e0f8af102b804 upstream.

    In the IR interrupt handler of cx88-input.c there's a 32-bit multiply
    overflow which causes IR pulse durations to be incorrectly calculated.

    This is a regression caused by commit 2997137be8eba.

    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/media/video/cx88/cx88-input.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/video/cx88/cx88-input.c
    +++ b/drivers/media/video/cx88/cx88-input.c
    @@ -523,7 +523,7 @@ void cx88_ir_irq(struct cx88_core *core)
    for (todo = 32; todo > 0; todo -= bits) {
    ev.pulse = samples & 0x80000000 ? false : true;
    bits = min(todo, 32U - fls(ev.pulse ? samples : ~samples));
    - ev.duration = (bits * NSEC_PER_SEC) / (1000 * ir_samplerate);
    + ev.duration = (bits * (NSEC_PER_SEC / 1000)) / ir_samplerate;
    ir_raw_event_store_with_filter(ir->dev, &ev);
    samples <<= bits;
    }



    \
     
     \ /
      Last update: 2011-05-19 20:15    [W:2.471 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site