lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: linux-next: build warning after merge of the scsi tree
    From
    On Wed, May 18, 2011 at 05:58, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
    >> --- a/drivers/target/tcm_fc/tfc_io.c
    >> +++ b/drivers/target/tcm_fc/tfc_io.c
    >> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
    >>                                                 "xid <0x%x>, remaining <0x%x>, "
    >>                                                 "lso_max <0x%x>\n",
    >>                                                 __func__, fp, ep->xid,
    >> -                                               remaining, lport->lso_max);
    >> +                                               (unsigned int)remaining,
    >> +                                               lport->lso_max);
    >
    > Given that "remaining" really is a length, surely it makes more sense to

    Exactly my comments ...

    > print it with %zd than to cast it and print it with %x ...

    ... except that size_t is unsigned, so %zu would be a little bit better.

    Gr{oetje,eeting}s,

                            Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
                                    -- Linus Torvalds
    \
     
     \ /
      Last update: 2011-05-19 18:25    [W:0.024 / U:29.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site