lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: manual merge of the tip tree with the sparc tree
From
Date
On Thu, 2011-05-19 at 15:37 +0200, Daniel Hellstrom wrote:


> diff --git a/arch/sparc/kernel/smp_32.c b/arch/sparc/kernel/smp_32.c
> index 41102c5..d5b3958 100644
> --- a/arch/sparc/kernel/smp_32.c
> +++ b/arch/sparc/kernel/smp_32.c
> @@ -156,11 +156,11 @@ void arch_send_call_function_ipi_mask(const struct
> cpumask *mask)
>
> void smp_resched_interrupt(void)
> {
> + irq_enter();
> + scheduler_ipi();
> local_cpu_data().irq_resched_count++;
> - /*
> - * do nothing, since it all was about calling re-schedule
> - * routine called by interrupt return code.
> - */
> + irq_exit();
> + /* re-schedule routine called by interrupt return code. */
> }

That doesn't look like an IPI, that looks like its calls the function on
the local cpu, which is completely pointless.


\
 
 \ /
  Last update: 2011-05-19 17:37    [W:0.145 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site