Messages in this thread | | | Date | Thu, 19 May 2011 16:59:53 +0200 | From | Frederic Weisbecker <> | Subject | Re: [RFC PATCH] perf: Split up buffer handling from core code |
| |
On Thu, May 19, 2011 at 04:43:28PM +0200, Peter Zijlstra wrote: > On Thu, 2011-05-19 at 16:14 +0200, Frederic Weisbecker wrote: > > > > Great. I kept it global because I read in a review from you > > that you wanted it to stay a visible API. But if you're fine > > with it internal, let's move it there. > > Well, its needed as an external symbol, but the inline isn't needed.
I thought it would be nice to keep it inline for core use, as it's called pretty often from the overflow path.
A solution is to have a perf_output_copy_inline() in internal.h and export it through perf_output_copy() in buffer.c
> I thought that the BTS code used it as well, but apparently that code > doesn't anymore (or never did any my memory if fuzzy).
I thought it did too, but it actually use perf_output_sample().
| |