lkml.org 
[lkml]   [2011]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] dma-debug: print some unfreed allocations
From
Date
On Mon, 2011-05-16 at 13:00 +0200, Roedel, Joerg wrote:
> > + /*
> > + * If we have, print out some stack traces for the allocations.
> > + * In case of module unload, the stack traces will be useless,
> > + * but instead of unloading the module you can manually unbind
> > + * the driver instead and get useful traces.
> > + */
> > + printk(KERN_WARNING "Showing traces for %d allocations:\n",
> > + DMA_DEBUG_NUM_PRINT_UNFREED);

> This is surely useful to developers, but can trash the dmesg if done
> unconditionally. I would prefer this verbose output to be configurable
> and off by default.

Are you thinking of runtime or compile time configuration? Kconfig entry
depending on stacktrace (or selecting it, depending on have_stacktrace)
would be easy enough.

johannes



\
 
 \ /
  Last update: 2011-05-19 00:49    [W:0.097 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site