lkml.org 
[lkml]   [2011]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] perf, x86: Fix event scheduler for constraints with overlapping counters

    * Peter Zijlstra <peterz@infradead.org> wrote:

    > > if (c->weight != w)
    > > continue;
    > >
    > > - for_each_set_bit(j, c->idxmsk, X86_PMC_IDX_MAX) {
    > > - if (!test_bit(j, used_mask))
    > > + /* for each bit in idxmsk starting from idx */
    > > + while (idx < X86_PMC_IDX_MAX) {
    > > + idx = find_next_bit(c->idxmsk, X86_PMC_IDX_MAX,
    > > + idx);
    >
    > I'd be mighty tempted to ignore that 80 column rule here ;-)

    Please put the body of the loop into a helper function, the function is large
    and there are countless col80 uglinesses in it!

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2011-05-18 23:23    [W:2.636 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site