lkml.org 
[lkml]   [2011]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] drivercore: revert addition of of_match to struct device
    From
    From: Grant Likely <grant.likely@secretlab.ca>
    Date: Wed, 18 May 2011 13:21:05 -0600

    > Commit b826291c, "drivercore/dt: add a match table pointer to struct
    > device" added an of_match pointer to struct device to cache the
    > of_match_table entry discovered at driver match time. This was unsafe
    > because matching is not an atomic operation with probing a driver. If
    > two or more drivers are attempted to be matched to a driver at the
    > same time, then the cached matching entry pointer could get
    > overwritten.
    >
    > This patch reverts the of_match cache pointer and reworks all users to
    > call of_match_device() directly instead.
    >
    > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

    Tested on SunBlade2500 and Niagara2+

    Acked-by: David S. Miller <davem@davemloft.net>


    \
     
     \ /
      Last update: 2011-05-18 23:07    [W:0.019 / U:1.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site