lkml.org 
[lkml]   [2011]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/10] job control: introduce JOBCTL_TRAP_STOP and use it for group stop trap
On 05/18, Oleg Nesterov wrote:
>
> So far I can't really understand why do we have both JOBCTL_TRAP_STOP and
> and JOBCTL_TRAPPING... Please ignore, I didn't read other patches yet.

OK, SEIZE sets JOBCTL_TRAP_STOP.

> Hmm. And afaics there is a bug in do_signal_stop(), after
> "[PATCH 6/9] job control: make task_clear_jobctl_pending() clear TRAPPING automatically"
> ->jobctl &= ~JOBCTL_STOP_SIGMASK is no longer safe. We can clear _TRAPPING
> without wakeup.

And this also affects ptrace_attach(PTRACE_SEIZE), TRAP_STOP is cleared
as well.

Oleg.



\
 
 \ /
  Last update: 2011-05-18 19:01    [from the cache]
©2003-2011 Jasper Spaans