lkml.org 
[lkml]   [2011]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options
    On 21:53 Tue 17 May     , Sam Ravnborg wrote:
    > On Tue, May 17, 2011 at 05:35:32PM +0200, Michal Marek wrote:
    > > For strings and integers, the config_is_xxx macros are useless and
    > > sometimes misleading:
    > >
    > > #define CONFIG_INITRAMFS_SOURCE ""
    > > #define config_is_initramfs_source() 1
    >
    > I'm late with this comment....
    > Could we introduce "config_is_foo" using a syntax that
    > does not break grepability?
    >
    > Maybe a syntax like this?
    >
    > #ifdef CONFIG_FOO
    >
    > and
    >
    > if (KCONFIG_FOO())
    >
    > Grepping for the use of a symbol is a very typical thing,
    > so we should try to keep this.
    > And with the suggested syntax above I expect fixdep to
    > catch up both usage types.
    I'll prefer kconfig_foo()
    not uppercase

    but if we use KCONFIG_FOO no need to touch fixdep

    Best Regards,
    J.


    \
     
     \ /
      Last update: 2011-05-18 07:31    [W:4.273 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site