On Wed, May 18, 2011 at 09:01:58PM +0800, Axel Lin wrote:> @@ -1886,13 +1886,15 @@ static int _regulator_get_voltage(struct regulator_dev *rdev)> if (sel < 0)> return sel;> ret = rdev->desc->ops->list_voltage(rdev, sel);> + goto out;> }Why are you adding this goto? It's not going to change anything...