[lkml]   [2011]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Perfromance drop on SCSI hard disk
    On 2011-05-17 08:09, Alex,Shi wrote:
    > On Mon, 2011-05-16 at 16:37 +0800, Alex,Shi wrote:
    >>>> what I mean is current sdev (other devices too) can still be added into
    >>>> starved list, so only does async execute for current q isn't enough,
    >>>> we'd better put whole __scsi_run_queue into workqueue. something like
    >>>> below on top of yours, untested. Not sure if there are other recursive
    >>>> cases.
    >>> verified the regression can be fully fixed by your patch (with my
    >>> suggested fix to avoid race). Can we put a formal patch upstream?
    >> Yes, we tested Jens patch alone and plus Shaohua's patch too. Both of
    >> them recovered SAS disk performance too. Now I am testing them on SSD
    >> disk with kbuild and fio cases, In theory, they will both work.
    > As expected, both patches has no effect on SSD disks in JBD.

    I will queue up the combined patch, it looks fine from here as well.

    Jens Axboe

     \ /
      Last update: 2011-05-17 09:23    [W:0.020 / U:19.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site