[lkml]   [2011]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/9] x86/kernel/cpu/intel.c: Initialize Enhanced REP MOVSB/STOSBenhanced
    > From: Fenghua Yu <>
    > If kernel intends to use enhanced REP MOVSB/STOSB, it must ensure
    > IA32_MISC_ENABLE.Fast_String_Enable (bit 0) is set and CPUID.(EAX=07H,
    > ECX=0H):
    > EBX[bit 9] also reports 1.

    I suspect the check at this place is not too useful because it will
    only work for the BSP. For all others it's too late -- the patching
    has already happened.

    So either this is a problem and then it should be checked on all CPUs.
    Or maybe not at all.

    The problem is that the alternative patching currently relies on being
    run early with no other CPUs. It has no race protections, support
    for cross modification etc.

    While it would be possible to fix that it would be quite complicated
    I bet.

    So I think it's better to just remove it unless it's a real problem
    in the field.


     \ /
      Last update: 2011-05-18 04:49    [W:0.022 / U:27.176 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site