Messages in this thread | | | Date | Wed, 18 May 2011 09:02:38 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH v2 7/9] mm: proc: move show_numa_map() to fs/proc/task_mmu.c |
| |
(2011/05/16 7:20), Stephen Wilson wrote: > Moving show_numa_map() from mempolicy.c to task_mmu.c solves several > issues. > > - Having the show() operation "miles away" from the corresponding > seq_file iteration operations is a maintenance burden. > > - The need to export ad hoc info like struct proc_maps_private is > eliminated. > > - The implementation of show_numa_map() can be improved in a simple > manner by cooperating with the other seq_file operations (start, > stop, etc) -- something that would be messy to do without this > change. > > Signed-off-by: Stephen Wilson<wilsons@start.ca> > Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > Cc: Hugh Dickins<hughd@google.com> > Cc: David Rientjes<rientjes@google.com> > Cc: Lee Schermerhorn<lee.schermerhorn@hp.com> > Cc: Alexey Dobriyan<adobriyan@gmail.com> > Cc: Christoph Lameter<cl@linux-foundation.org>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |