lkml.org 
[lkml]   [2011]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] checkpatch.pl: Add check for task comm references
Date
From
On Tue, 17 May 2011 22:47:43 +0200, John Stultz wrote:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d867081..a67ea69 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2868,6 +2868,13 @@ sub process {
> WARN("usage of NR_CPUS is often wrong - consider using
> cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" .
> $herecurr);
> }
> +# check for current->comm usage
> + our $common_comm_vars = qr{(?x:

It should by "my" not "our".

> + current|tsk|p|task|curr|chip|t|object|me
> + )};

Also, I would stick it on a single line, ie.:

my $comm_vars = qr/current|tsk|p|task|curr|chip|t|object|me/;

> + if ($line =~ /\b($common_comm_vars)\s*->\s*comm\b/) {

The parens are not needed.

> + WARN("comm access needs to be protected. Use get_task_comm, or
> printk's \%ptc formatting.\n" . $herecurr);
> + }

Empty line should be here.

> # check for %L{u,d,i} in strings
> my $string;
> while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo--


\
 
 \ /
  Last update: 2011-05-17 23:07    [W:0.080 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site