lkml.org 
[lkml]   [2011]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V5 4/6 net-next] vhost: vhost TX zero-copy support
From
Date
On Tue, 2011-05-17 at 18:28 +0300, Michael S. Tsirkin wrote:
> Which is the order the descriptors are put on avail ring.
> By design, guest should not depend on used ring entries
> being in order with avail ring (and btw with virtio block,
> they aren't). If it does, it's a bug I think.

Ok, I thought, the order should be maintained.

> > The original code has no problem, because it gets one head and pass
> that
> > head to vhost_add_used one by one once done the copy. So it's in
> > sequence.
> >
> > This issue can easily recreate without zerocopy patch by simply
> changing
> > the order from "head return vhost_get_vq_desc" when passing to
> > vhost_add_used.
> >
> > Thanks
> > Shirley
>
> Ah, did you try that? Could you post this patch pls?
> This seems to imply a bug in guest virtio.

I am creating the patch against net-next for you to test today.

Thanks
Shirley



\
 
 \ /
  Last update: 2011-05-17 17:37    [W:0.090 / U:3.332 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site