Messages in this thread | | | Date | Tue, 17 May 2011 10:34:41 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter. |
| |
On 05/17/11 10:25, Jonathan Cameron wrote: > On 05/17/11 08:06, Fabien Marteau wrote: >> Hi Guenter, >> >> Thanks for the review. >> >> On 16/05/2011 17:39, Guenter Roeck wrote: >>> On Mon, May 16, 2011 at 09:39:14AM -0400, fabien.marteau@armadeus.com wrote: >>>> From: Fabien Marteau <fabien.marteau@armadeus.com> >>>> >>>> >>> Some description, such as "Dhis driver adds support for xxx" would be nice. >>> >>> Also, I wonder if this driver belongs into hwmon in the first place. It is >>> a generic ADC chip with high conversion rate. iio would probably be more >>> appropriate and also much better in supporting high speed readings. >> I provided this driver "as is" because it's a driver that work well on >> our platform. I thought that iio was not stable enough driver framework >> to be used. >> I can rewrite it under iio framework but I have no time for this moment >> to do that. You think it's better to wait for an iio driver or to >> continue commiting this ? > I'd say that if you primary use is hwmon, put it there for now and we can think > about moving it at a later date depending on how people are actually using it. > Guenter, would that be ok for you? Having actually taken a look at the code, it's straight forward, so if you are using it as a general purpose adc then I'm happy to port to IIO sometimes soonish... Will need some testing at somepoint though.
Jonathan
| |