lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] checkpatch.pl: Add check for task comm references
From
Date
On Mon, 2011-05-16 at 14:34 -0700, David Rientjes wrote:
> On Mon, 16 May 2011, Michal Nazarewicz wrote:
> > > Now that accessing current->comm needs to be protected,
> > > +# check for current->comm usage
> > > + if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
> > Not a checkpatch.pl expert but as far as I'm concerned, that looks reasonable.

I think the only checkpatch expert is Andy Whitcroft.

You don't need (?: just (

curr, chip and object are pretty common (see below)

An option may be to specify another variable
common_comm_vars or something like it

our $common_comm_vars = qr{(?x:
current|tsk|p|task|curr|chip|t|object|me
)};

and use that variable in your test

Treewide:

$ grep -rPoh --include=*.[ch] "\b\w+\s*\-\>\s*comm\b" * | \
sort | uniq -c | sort -rn
319 current->comm
59 tsk->comm
32 __entry->comm
24 p->comm
23 event->comm
19 task->comm
18 thread->comm
15 self->comm
14 c->comm
13 curr->comm
12 chip->comm
9 t->comm
8 object->comm
8 me->comm
(others not shown)

Perf:

$ grep -rP --include=*.[ch] "\b\w+\s*\-\>\s*comm\b" tools/perf include/trace | \
sort | uniq -c | sort -rn
32 __entry->comm
23 event->comm
18 thread->comm
15 self->comm
14 c->comm
10 current->comm
3 tsk->comm
3 task->comm
3 p->comm
(others not shown)



\
 
 \ /
  Last update: 2011-05-17 01:07    [W:0.051 / U:40.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site