lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] checkpatch.pl: Add check for task comm references
On Mon, 16 May 2011, Michal Nazarewicz wrote:

> > Now that accessing current->comm needs to be protected,
> > @@ -2868,6 +2868,10 @@ sub process {
> > WARN("usage of NR_CPUS is often wrong - consider using
> > cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" .
> > $herecurr);
> > }
> > +# check for current->comm usage
> > + if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
>
> Not a checkpatch.pl expert but as far as I'm concerned, that looks reasonable.
>
> I was sort of worried that t->comm could produce quite a few false positives
> but all its appearances in the kernel (seem to) refer to task.
>

It's guaranteed to generate false positives since perf events uses a field
of the same name to store a thread's comm, so I think the most important
thing is for the checkpatch output to specify that this _may_ be a
dereference of a thread's comm that needs get_task_comm() or %ptc.


\
 
 \ /
  Last update: 2011-05-16 23:37    [W:0.210 / U:13.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site