lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] module: Use binary search in lookup_symbol()
From
Date
On Mon, 2011-05-16 at 14:01 -0700, Joe Perches wrote:
> On Mon, 2011-05-16 at 22:23 +0200, Alessio Igor Bogani wrote:
> > Signed-off-by: Alessio Igor Bogani <abogani@kernel.org>
> > diff --git a/kernel/module.c b/kernel/module.c
> > @@ -2055,10 +2055,8 @@ static const struct kernel_symbol *lookup_symbol(const char *name,
> > const struct kernel_symbol *stop)
> > {
> > const struct kernel_symbol *ks = start;
> > - for (; ks < stop; ks++)
> > - if (strcmp(ks->name, name) == 0)
> > - return ks;
> > - return NULL;
> > + return bsearch(name, start, stop - start,
> > + sizeof(struct kernel_symbol), cmp_name);
[]
> why cmp_name and not strcmp?

Nevermind, cmp_name is obviously correct.



\
 
 \ /
  Last update: 2011-05-16 23:11    [W:0.094 / U:2.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site