lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + mm-remove-dependency-on-config_flatmem-from-online_page.patch added to -mm tree
On Tue, 3 May 2011, akpm@linux-foundation.org wrote:

>
> The patch titled
> mm: remove dependency on CONFIG_FLATMEM from online_page()
> has been added to the -mm tree. Its filename is
> mm-remove-dependency-on-config_flatmem-from-online_page.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: mm: remove dependency on CONFIG_FLATMEM from online_page()
> From: Daniel Kiper <dkiper@net-space.pl>
>
> Memory hotplug code strictly depends on CONFIG_SPARSEMEM. It means that
> code depending on CONFIG_FLATMEM in online_page() is never compiled.
> Remove it because it is not needed anymore.
>

The changelog should read:

online_pages() is only compiled for CONFIG_MEMORY_HOTPLUG_SPARSE,
so there is no need to support CONFIG_FLATMEM code within it.

This patch removes code that is never used.

since this code is dependant on CONFIG_MEMORY_HOTPLUG_SPARSE, not
CONFIG_SPARSEMEM.

After that:

Acked-by: David Rientjes <rientjes@google.com>

> Signed-off-by: Daniel Kiper <dkiper@net-space.pl>
> Acked-by: Dave Hansen <dave@linux.vnet.ibm.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> mm/memory_hotplug.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff -puN mm/memory_hotplug.c~mm-remove-dependency-on-config_flatmem-from-online_page mm/memory_hotplug.c
> --- a/mm/memory_hotplug.c~mm-remove-dependency-on-config_flatmem-from-online_page
> +++ a/mm/memory_hotplug.c
> @@ -374,10 +374,6 @@ void online_page(struct page *page)
> totalhigh_pages++;
> #endif
>
> -#ifdef CONFIG_FLATMEM
> - max_mapnr = max(pfn, max_mapnr);
> -#endif
> -
> ClearPageReserved(page);
> init_page_count(page);
> __free_page(page);


\
 
 \ /
  Last update: 2011-05-16 22:37    [W:0.036 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site