[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08
On Mon, May 16, 2011 at 1:52 PM, Lennart Sorensen
<> wrote:
>> >  struct mpc8xxx_spi_probe_info *to_of_pinfo(struct fsl_spi_platform_data *pdata)
>> >  {
>> >        return container_of(pdata, struct mpc8xxx_spi_probe_info, pdata);
>> >  }
>> > +EXPORT_SYMBOL(to_of_pinfo);
>> Hmmm,. this is not so good because it exports rather generically named
>> functions out to the global namespace.  These functions should be
>> renamed to have an mpc8xxx_spi_ prefix before exporting.
>> Otherwise this patch looks good.
> Hmm, yeah it did look like a crappy function name, but I just wanted to
> fix the problem, not try to guess what the author of the code intended.
> Prefixing it makes sense.

Alternately, you can move that function to the common header as a
static inline. It's just a container_of() wrapper after all, so
moving it would probably be better.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2011-05-16 22:05    [W:0.052 / U:9.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site