lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] job control: make task_clear_jobctl_pending() clear TRAPPING automatically
Hello,

On Mon, May 16, 2011 at 06:00:19PM +0200, Oleg Nesterov wrote:
> > It's a safety mechanism. We shouldn't have TRAPPING set when no
> > stop/trap is pending and the above establishes that invariant
>
> Hmm. I thought that SIGCONT should add the new TRAPPING... My head spins.

So, it's two-fold, but we better talk about this with actual patches.

* SIGCONT always clears pending group stop - ie. JOBCTL_STOP_PENDING.
If clearing of that flag leaves no group stop / trap condition
pending (group stop pending was the only condition), it
automatically clears TRAPPING.

* SIGCONT schedules JOBCTL_TRAP_STOP (STOP trap site for ptracer) and
schedules TRAPPING, if tracee is already in TRAP_STOP for
notification. Note that this condition doesn't interact with the
above action.

> My only point, I still think that it is better to not apply these
> preparations right now, without the next SEIZE/etc changes.

Sure thing. As long as you don't see anything obviously wrong in the
prep patches, the rest of the series should be easier to review.

Anyways, will post soon.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-05-16 18:13    [W:0.027 / U:8.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site