lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH UPDATED 8/9] ptrace: move JOBCTL_TRAPPING wait to wait(2) and ptrace_check_attach()
On 05/16, Tejun Heo wrote:
>
> On Mon, May 16, 2011 at 02:11:42PM +0200, Oleg Nesterov wrote:
> > Anyway, restart_syscall() is not right for do_wait(), especially with the
> > next patch. If the caller was woken by the real signal which has a handler,
> > we should not restart without SA_RESTART.
>
> I don't think it really matters and might even be incorrect if we do
> that. e.g. we would introduce -EINTR failure to WNOHANG waits.

Agreed.

> The only case that I think of where this could be visible is sleeping
> wait(2), checking the state again after being woken up and gets signal
> while waiting for TRAPPING. In this case, yeap, we should fail with
> -EINTR.

Yes, -EINTR or restart if SA_RESTART.

Oleg.



\
 
 \ /
  Last update: 2011-05-16 18:09    [W:0.041 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site