lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 08/15] sched: throttle cfs_rq entities which exceed their local runtime
From
Date
On Tue, 2011-05-03 at 02:28 -0700, Paul Turner wrote:
> + task_delta = -cfs_rq->h_nr_running;
> + for_each_sched_entity(se) {
> + struct cfs_rq *qcfs_rq = cfs_rq_of(se);
> + /* throttled entity or throttle-on-deactivate */
> + if (!se->on_rq)
> + break;
> +
> + if (dequeue)
> + dequeue_entity(qcfs_rq, se, DEQUEUE_SLEEP);
> + qcfs_rq->h_nr_running += task_delta;
> +
> + if (qcfs_rq->load.weight)
> + dequeue = 0;
> + }
> +
> + if (!se)
> + rq->nr_running += task_delta;

So throttle is like dequeue, it removes tasks, so why then insist on
writing it like its adding tasks? (I see you're adding a negative
number, but its all just weird).


\
 
 \ /
  Last update: 2011-05-16 18:07    [W:0.280 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site