lkml.org 
[lkml]   [2011]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH v7 10/14] memcg: dirty page accounting support routines
On Sun, 15 May 2011 12:56:00 -0700
Greg Thelen <gthelen@google.com> wrote:

> On Fri, May 13, 2011 at 2:56 AM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > On Fri, 13 May 2011 01:47:49 -0700
> > Greg Thelen <gthelen@google.com> wrote:

> >> +static unsigned long mem_cgroup_page_stat(struct mem_cgroup *mem,
> >> +                                       enum mem_cgroup_page_stat_item item)
> >
> > How about mem_cgroup_file_cache_stat() ?
>
> The suggested rename is possible. But for consistency I assume we
> would also want to rename:
> * mem_cgroup_local_page_stat()
> * enum mem_cgroup_page_stat_item
> * mem_cgroup_update_page_stat()
> * mem_cgroup_move_account_page_stat()
>

Yes, maybe clean up is necessary.

> I have a slight preference for leaving it as is,
> mem_cgroup_page_stat(), to allow for future coverage of pages other
> that just file cache pages. But I do not feel very strongly.
>

ok, I'm not have big concern on naming for now. please do as you like.

Thanks,
-Kame



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-05-16 08:07    [W:0.069 / U:20.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site