Messages in this thread |  | | Date | Sun, 15 May 2011 17:44:30 -0400 (EDT) | | Subject | Re: [PATCH net-next-2.6] net: ping: dont call udp_ioctl() | | From | David Miller <> |
| |
From: Solar Designer <solar@openwall.com> Date: Mon, 16 May 2011 01:30:18 +0400
> On Sun, May 15, 2011 at 10:18:40AM +0200, Eric Dumazet wrote: >> Do we really need to support SIOCOUTQ and SIOCINQ ioctls for ping >> sockets ? > > Probably not. > >> BTW, link >> (ftp://mirrors.kernel.org/openwall/Owl/current/sources/Owl/packages/iputils/iputils-ss020927.tar.gz ) provided in http://openwall.info/wiki/people/segoon/ping is not working. >> >> I had to manually patch iputils-s20101006.tar.bz2 instead. > > Oh, the link broke precisely because we updated to s20101006 since then, > and the link was to our current branch. I've just updated the wiki page > to include links both for iputils-ss020927 and for iputils-s20101006 > (both original tarballs and patches). > >> [PATCH net-next-2.6] net: ping: dont call udp_ioctl() >> >> udp_ioctl() really handles UDP and UDPLite protocols. >> >> 1) It can increment UDP_MIB_INERRORS in case first_packet_length() finds >> a frame with bad checksum. >> >> 2) It has a dependency on sizeof(struct udphdr), not applicable to >> ICMP/PING >> >> If ping sockets need to handle SIOCINQ/SIOCOUTQ ioctl, this should be >> done differently. >> >> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> >> CC: Vasiliy Kulikov <segoon@openwall.com> > > Reviewed-by: Solar Designer <solar@openwall.com>
Just get rid of ping_ioctl() entirely, as that is the effect of this change since inet_ioctl() returns -ENOIOCTLCMD when sk_prot->ioctl is NULL.
Also get rid of asm/ioctls.h since that will be no longer needed.
Thanks.
|  |